tuxji commented on a change in pull request #652:
URL: https://github.com/apache/daffodil/pull/652#discussion_r723247588
##########
File path: .github/workflows/main.yml
##########
@@ -34,7 +34,7 @@ jobs:
fail-fast: false
matrix:
distribution: [ temurin ]
- java_version: [ 8, 11, 16 ]
+ java_version: [ 8, 11, 17 ]
scala_version: [ 2.12.15 ]
Review comment:
What impact do Daffodil users need to be aware of? I checked and
build.sbt already tells sbt to build Daffodil with Scala 2.12.15 so it's not as
if developers or users need to take any special action such as installing
something, right?
```scala
lazy val commonSettings = Seq(
organization := "org.apache.daffodil",
version := "3.2.0-SNAPSHOT",
scalaVersion := "2.12.15",
crossScalaVersions := Seq("2.12.15"),
scalacOptions ++= Seq(
"-feature",
"-deprecation",
"-language:experimental.macros",
"-unchecked",
"-Xfatal-warnings",
"-Xxml:-coalescing",
"-Xfuture"
),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
