stevedlawrence commented on pull request #651: URL: https://github.com/apache/daffodil/pull/651#issuecomment-940998942
There was a comment about the LICENSE file that I can't respond to now because it's "outdated". That's an annoying github feature, but with regards to removing passera from the META-INF/LICENSE file: > Why would we think runtime1-unparser doesn't need passera? > > Anyway for runtime1-layers I copied LICENSE and NOTICES from runtime1-unparser The LICENSE file in META-INF directory is the license information specific to that jar and covers only what is in that jar. Even though the jar depends on passera, that doesn't change the license of the jar because nothing in it is passera. On the other hand, the META-INF/LICENSE for daffodil-lib does need to mention passera and other things, because that jar actually contains the compiled code of passera and other things. LICENSE files only need to cover what is distributed in that bundle. That's why our root LICENSE file include licenses of things in our source code, the daffodil-cli/bin.LICENSE file covers all that plus the licenses of all our dependencies (since dependencies end up in the distributed tar/zip/rpm), and most jar LICENSE files don't have anything extra. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
