tuxji commented on pull request #665: URL: https://github.com/apache/daffodil/pull/665#issuecomment-952069463
I found the previous PR where we discussed using `-std`: [last comment](https://github.com/apache/daffodil/pull/553#discussion_r626592946). In short, `-pedantic -std=gnu99` would accept the original for loop as-is (even on CentOS 7 since it came out in 2014). However, I said some C compilers might not understand `-pedantic -std=gnu99` so we should play it conservative with build.sbt's compiler flags, reserving the additional `-Wall -Wextra -pedantic -std=gnu99` flags for c/Makefile. I didn't see any warning or error messages when compiling the original for loop with c/Makefile and our continuous integration C compilers are modern enough to make gnu99 their default level, but CentOS 7's compiler was just old enough that its default level was even earlier than gnu99. If we want to play it a little less conservative, we probably could add `-std=gnu99` to both build.sbt and CodeGenerator.scala but I'll content myself with fixing the for loop instead. If there's enough request on this PR, I can add the flag in a future runtime2 PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
