stevedlawrence commented on a change in pull request #47:
URL: https://github.com/apache/daffodil-vscode/pull/47#discussion_r739191654
##########
File path: .vscodeignore
##########
@@ -12,22 +12,25 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-.vscode/**/*
-.gitignore
-.travis.yml
-appveyor.yml
-src/**/*
-out/tests/**/*
-**/*.js.map
+# build
build
-sampleworkspace
+create_vsix.sh
node_modules
-tsconfig.json
out
-sampleWebWorkerWorkspace
-sampleWorkspace
+src
+
+# config
+.asf.yml
+.eslintignore
+.github
+.gitignore
+.vscode
+tsconfig.json
-# sbt directories
+# scala
+.bsp
+.scalafmt.conf
+build.sbt
target
Review comment:
Looks fine to me, but what are you thoughts on turning this into a
whitelist so that we don't need to remember to modify this file when we add new
files? I was able to find another vscode repo that does this by ignoring
everything with `*` and then adding individual files back with `!`:
https://github.com/Microsoft/vscode-mono-debug/blob/main/.vscodeignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
