tuxji opened a new pull request #673:
URL: https://github.com/apache/daffodil/pull/673


   Fix pedantic warning "ISO C99 doesn't support unnamed structs/unions"
   found when compiling nested.dfdl.xsd's NestedUnion example with
   current Makefile's CFLAGS.  Installed centos7 vagrant box and verified
   that both gcc and clang support "-Wall Wextra -Wpedantic -std=gnu11"
   all the way back to gcc-4 and clang-3 on CentOS 7.  Therefore, will
   raise runtime2's minimum C language support level to ISO C11 with GNU
   extensions and make all the places where Daffodil calls the C compiler
   pass -std=gnu11 to the C compiler to compile code with the same
   minimum C level.  ISO C11 also allows "for (" loops to define loop
   variables in place so we can make that change too.
   
   build.sbt - Change cFlags to use "-Wpendantic -std=gnu11" instead of
   "-pedantic -std=gnu99".
   
   Makefile - Change CFLAGS to use "-Wpedantic -std=gnu11" instead of
   "-pedantic -std=gnu99".  Slightly improve Makefile comments' step by
   step instructions as well.
   
   daffodil_getopt.c, xml_reader.c, xml_writer.c, errors.c, infoset.c -
   Define loop variables in place within "for (" loops.
   
   CodeGenerator.scala - Pass "-std=gnu11" to C compiler.  Now all places
   that call the C compiler will compile with the same minimum C level.
   
   NestedUnion/generated_code.[ch] - Replace with re-generated code.
   These files are manually updated and their only purpose is to display
   how the generated code changes as changes are made to runtime2 over
   time.
   
   DAFFODIL-2578


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to