stevedlawrence commented on a change in pull request #51:
URL: https://github.com/apache/daffodil-vscode/pull/51#discussion_r758482420



##########
File path: build/bin.NOTICE
##########
@@ -158,3 +158,32 @@ Scala XML 
(lib/org.scala-lang.modules.scala-xml_<VERSION>.jar)
   scala-xml includes software developed at
   LAMP/EPFL (https://lamp.epfl.ch/) and
   Lightbend, Inc. (https://www.lightbend.com/).
+
+ip4s (lib/com.comcast:ip4s-core.jar-<VERSION>.jar)
+  IP Addresses for Scala and Scala.js
+  Copyright 2018 Comcast Cable Communications Management, LLC
+
+Gson (lib/com.google.code.gson:gson.jar-<VERSION>.jar)
+  Copyright 2008 Google Inc.
+
+decline (lib/com.monovore:decline-<VERSION>.jar, 
lib/com.monovore:decline-effect-<VERSION>.jar)
+
+RxJava (lib/io.reactivex.rxjava2:rxjava-<VERSION>.jar)
+  Copyright (c) 2016-present, RxJava Contributors.
+
+RxJava (lib/io.reactivex.rxjava2:rxjava-<VERSION>.jar)
+  Copyright (c) 2016-present, RxJava Contributors.

Review comment:
       Gotcha. This file only needs to include NOTICE's from dependencies, so 
these projects can be removed form this file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to