mbeckerle commented on a change in pull request #696:
URL: https://github.com/apache/daffodil/pull/696#discussion_r764143568
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DaffodilParseOutputStreamContentHandler.scala
##########
@@ -42,7 +43,7 @@ import org.xml.sax.Locator
*/
class DaffodilParseOutputStreamContentHandler(out: OutputStream, pretty:
Boolean = false)
extends ContentHandler with Indentable {
- private val writer = new OutputStreamWriter(out)
+ private val writer = new OutputStreamWriter(out, Charset.forName("UTF-8"))
Review comment:
SonarQube (or other code quality scanners) may have a feature for this.
What we need sounds pretty simple and broadly useful: deprecate a method by
rule from outside. I.e., "don't use this method" from Java or Scala (or
anything else that can call it)
There is a plug-in way to create custom checkers, but they're
language-being-scanned specific, not sure they have a scala API for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
