mbeckerle commented on a change in pull request #698:
URL: https://github.com/apache/daffodil/pull/698#discussion_r765920812
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/SAXInfosetInputter.scala
##########
@@ -207,7 +207,8 @@ class SAXInfosetInputter(
}
} catch {
case e: Exception => {
Review comment:
Catch of Exception requires documentation. As part of figuring out how
to get the change line covered by a test, you should add comments to this scala
code as to why catching Exception is ok in this case.
Does anyone (@stevedlawrence @olabusayoT ) know why this is ok? Normally
catching Exception or Throwable is almost always an error. Please chime in.
If this in fact should not be Exception, but something narrower, then let's
fix that.
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/api/DFDLParserUnparser.scala
##########
@@ -263,9 +263,11 @@ object DFDL {
/**
* Used in SAXInfosetEvent.causeError to identify when an unexpected error
occurs
*/
- class DaffodilUnhandledSAXException(description: String, cause: Exception)
- extends org.xml.sax.SAXException(description, cause)
+ class DaffodilUnhandledSAXException(description: String, cause: Exception)
+ extends org.xml.sax.SAXException(description, cause) {
+ def this(cause: Exception)= this(null, cause)
Review comment:
A unit test (not a TDML test, just regular unit test) should construct
one of these objects so this line is covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
