Shanedell commented on a change in pull request #63:
URL: https://github.com/apache/daffodil-vscode/pull/63#discussion_r772458342
##########
File path: server/core/src/templates/bash-template
##########
@@ -263,8 +263,8 @@ run() {
java_opts="${JAVA_OPTS}"
fi
- if [[ "$DAFFODIL_DEBUG_CLASSPATH" != "" ]]; then
- app_classpath="$app_classpath:$DAFFODIL_DEBUG_CLASSPATH"
+ if [[ "$daffodilDebugClasspath" != "" ]]; then
Review comment:
So the change most dealt with the linting of TypeScript. In the
`daffodilDebugger.ts` file when we export the ENV variable it will give a
warning about `DAFFODIL_DEBUG_CLASSPATH` as TypeScript wants it be camel cased.
This actually deals with eslint, which in another PR we switch from eslint to
prettier so this may not be an issue once the eslint packages and files are
removed. So if you would like this to be reverted I can do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
