stevedlawrence commented on a change in pull request #748:
URL: https://github.com/apache/daffodil/pull/748#discussion_r801990109
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/AlignedMixin.scala
##########
@@ -202,9 +202,15 @@ trait AlignedMixin extends GrammarMixin { self: Term =>
val parentAlignmentApprox =
Review comment:
Yeah, I did not attempt to fix that issue. I don't think we've come
across any formats that run into this issue, especially since most formats
actually have really simple alignment--either all bits or all bytes. My guess
is that's why it's marked as minor.
My goal with with this PR was to just get the issues with alignment
deadlocks resolved that were affecting real world schemas that Mike found. This
alignment algorithm is complex enough that I'm sure there are some edge cases
we just don't handle correctly, some we probably don't even know about yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
