stevedlawrence commented on pull request #762:
URL: https://github.com/apache/daffodil/pull/762#issuecomment-1050025941


   @alexanderrevello, looks good, can you please add the bug number 
(DAFFODIL-2575) to the end of the commit message, and update the commit message 
to be more accurate? I think "restore unneeded input file" doesn't really make 
sense in the context of just this single commit. See Step 10 of the [Code 
Contributor 
Workflow](https://cwiki.apache.org/confluence/display/DAFFODIL/Code+Contributor+Workflow)
 for commit message guidance.
   
   Also, I just noticed your git commit name is `U-COLUMBIA\arevello` and email 
is `[email protected]` You don't have to change this, but 
this looks like some default set by git. Might be worth updating this since 
you'll need to amend the commit to add the bug number anyway.
   
   Once fixed, you can force push and this should be good to merge :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to