tuxji commented on code in PR #780: URL: https://github.com/apache/daffodil/pull/780#discussion_r841861488
########## daffodil-cli/bin.NOTICE: ########## @@ -46,49 +46,74 @@ The following NOTICE information applies to binary components distributed with t Original source copyright: Copyright (c) 2008 Alexander Beider & Stephen P. Morse. -- lib/commons-io.commons-io-<VERSION>.jar +- commons-io.commons-io-<VERSION>.jar Apache Commons IO Copyright 2002-2021 The Apache Software Foundation -- lib/commons-logging.commons-logging-<VERSION>.jar +- commons-logging.commons-logging-<VERSION>.jar Apache Commons Logging Copyright 2003-2014 The Apache Software Foundation -- lib/org.apache.httpcomponents.httpclient-<VERSION>.jar +- org.apache.daffodil.daffodil-lib-<VERSION>.jar Review Comment: Yes, I added this notice from daffodil-lib/NOTICE for this reason, because it attributes one class to the Scala library. Doing this also allowed me to simplify the Scala library notice elsewhere in bin.NOTICE, since it used to mention that class in that place. I think putting the attribution under daffodil-lib's jar makes sense because we will know we need to check, or update, daffodil-lib/NOTICE if anything changes in the future regarding that daffodil-lib class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
