stevedlawrence commented on PR #87:
URL: https://github.com/apache/daffodil-site/pull/87#issuecomment-1087914611
Ah, I now see why you removed the "VS Code Extension", since we use the
`title` in places where we want to show just the number. But we do want `VS
Code Extension` in some places...
What if you switch back to just the version number in the title like you had
and then we have this change:
```diff
diff --git a/site/_includes/themes/apache/_navigation.html
b/site/_includes/themes/apache/_navigation.html
index 1205789..39050f9 100644
--- a/site/_includes/themes/apache/_navigation.html
+++ b/site/_includes/themes/apache/_navigation.html
@@ -63,7 +63,7 @@
{% else %}
<div class="title">
<div class="container">
- <h2>{% if page.collection == "releases" %}{% if page.apache %}Apache {%
endif %}Daffodil {% endif %}{{ page.title }}</h2>
+ <h2>{% if page.collection == "releases" %}{% if page.apache %}Apache {%
endif %}Daffodil {% endif %}{% if page.collection == "vscode" %}VS Code
Extension {% endif %}{{ page.title }}</h2>
</div>
</div>
{% endif %}
diff --git a/site/_includes/themes/apache/default.html
b/site/_includes/themes/apache/default.html
index 3adc99a..9f68b90 100644
--- a/site/_includes/themes/apache/default.html
+++ b/site/_includes/themes/apache/default.html
@@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Apache Daffodil | {{ page.title }}</title>
+ <title>Apache Daffodil | {% if page.collection == "vscode" %}VS Code
Extension {% endif %}${{ page.title }}</title>
{% if page.description %}<meta name="description" content="{{
page.description }}">{% endif %}
<meta name="author" content="{{ site.author.name }}">
```
Not tested, but the idea is that the `title` variable is just the version
number like you had before, and the places where we display that version number
(the <title> tag and the page header) and want more than just the version we
special case and add the `VS Code Extension` string.
It's a big hacky, but minimizes changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
