stevedlawrence commented on PR #89:
URL: https://github.com/apache/daffodil-site/pull/89#issuecomment-1105650841

   I don't know if GitHub has a way to view the generated artifacts as a web 
page. And even if they could, I think there might be issues since we use 
absolute paths to resources (like font files). So the URL would need to be 
something like
   
   `https://daffodil-site-pull-request-XYZ.artifacts.github.com`
   
   They don't have anything like that as far as I'm aware.
   
   Downloading a zip has a similar problem with absolute paths, but running a 
simple http sever would solve that issue after downloading the artifact, e.g.
   ```bash
   # download artifact.zip from github PR
   unzip artficat.zip
   cd artifact
   python3 -m http.server
   ```
   Not hard, but it isn't quite as simple as downloading files and open them in 
a browser--and I can never seem to remember this python http server command.
   
   I personally find it easier to just checkout out the PR branch and then 
copy/paste the jekyll command from the README.
   
   Another alternative would be to have a PR workflow that outputs a diff the 
generated HTML files? Sometimes just viewing the diff might be enough? It's 
still not great since you can't comment, and diffs of generated HTML isn't 
usually easy to look at, but it's another option. And it wouldn't require 
downloading anything since the diff would just be in the GitHub action log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to