stevedlawrence commented on code in PR #781:
URL: https://github.com/apache/daffodil/pull/781#discussion_r872656601
##########
project/Dependencies.scala:
##########
@@ -32,6 +32,7 @@ object Dependencies {
"com.typesafe" % "config" % "1.4.2",
"org.apache.logging.log4j" %% "log4j-api-scala" % "12.0",
"org.apache.logging.log4j" % "log4j-api" % "2.17.2",
+ "org.apache.logging.log4j" % "log4j-core" % "2.17.2",
"org.apache.logging.log4j" % "log4j-core" % "2.17.2" % "it,test",
Review Comment:
I don't think this comment was addressed. log4-core should only be a
dependency to the daffodil-tdml-processor project, not as a core dependency.
And the TDMLAppender and related code also wants to be moved to the same
project. Other DFDL implemenations (e.g. IBM DFDL) may use a different
mechanism for their logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
