alexanderrevello commented on code in PR #768: URL: https://github.com/apache/daffodil/pull/768#discussion_r876239632
########## daffodil-runtime1/src/main/resources/META-INF/services/org.apache.daffodil.charsets.CharsetCompiler: ########## @@ -0,0 +1,31 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# PLEASE NOTE: +# +# These are in src/test/resources not src/main/resources because they're not +# "real" in the sense of being fully featured. E.g., AIS only does the payload +# armoring, not everything else about AIS. IPv4 just does the IPv4 header, not +# TCP, UDP, ICMP, etc. all of which have related checksum algorithms that should +# share code. A real CheckDigits has to have different layer length kinds supported +# so that one can compute check digits from elements with different +# of length kinds. +# +# These are partial/subsets of "real" functionality that give us test coverage +# of the layering features of Daffodil. They can be reused to create "real" +# layering, but one should expect to have to adapt their code substantially. +# +org.apache.daffodil.processors.charset.CustomNonByteSizeCharsetCompiler +org.apache.daffodil.processors.charset.CustomJavaCharsetCompiler Review Comment: file was removed as it was no longer needed. Correct version is in the test folder ########## daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/EvEncoding.scala: ########## @@ -93,10 +93,11 @@ abstract class CharsetEvBase(encodingEv: EncodingEvBase, tci: DPathCompileInfo) override def compute(state: ParseOrUnparseState) = { val encString = encodingEv.evaluate(state) - val cs = CharsetUtils.getCharset(encString) Review Comment: reverted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
