stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r883876228
##########
package.json:
##########
@@ -63,24 +75,42 @@
"webpack-cli": "^3.3.12"
},
"main": "./dist/ext/extension.js",
- "browser": "./dist/web/extension.js",
"activationEvents": [
+ "onLanguage:dfdl",
"onDebugResolve:dfdl",
"onDebugDynamicConfigurations:dfdl",
"onCommand:extension.dfdl-debug.getProgramName",
"onCommand:extension.dfdl-debug.getDataName",
"onCommand:extension.dfdl-debug.runEditorContents",
"onCommand:extension.dfdl-debug.debugEditorContents",
- "onCommand:launch.config"
+ "onCommand:launch.config",
+ "onCommand:data.edit",
+ "onCommand:omega_edit.version",
+ "onCommand:toggle.experimental"
],
"workspaceTrust": {
"request": "never"
},
"contributes": {
- "snippets": [
+ "languages": [
{
- "language": "xml",
- "path": "./snippets/dfdl.json"
+ "id": "dfdl",
+ "aliases": [
+ "dfdl",
+ "dfdl"
+ ],
+ "extensions": [
+ ".xsd",
+ ".xml"
Review Comment:
> When we were testing we only allowed for .dfdl.xsd however in some schemas
they were using just .xsd
This is probably fine. I think it's reasonable to enforce that this only
works with .dfdl.xsd files. Alternatively (if possible) you could have a
setting that says what extensions to treat as DFDL files. It would probably
only want to default to dfdl.xsd, but people could add .xml/xsd if they wanted.
I'm not sure if vscode supports that or if extensions must be hardcoded in
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
