Shanedell commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r883932725


##########
package.json:
##########
@@ -392,6 +474,99 @@
             "default": ""
           }
         }
+      },
+      {
+        "type": "object",
+        "title": "vscode-dfdl",
+        "properties": {
+          "vscode-dfdl.enabled": {
+            "type": "boolean",
+            "default": true,
+            "description": "Enables the highlighting and status bar",
+            "scope": "resource"
+          },
+          "vscode-dfdl.showPath": {
+            "type": "boolean",
+            "default": true,
+            "description": "Enables showing tag's path in status bar",
+            "scope": "resource"
+          },
+          "vscode-dfdl.showRuler": {
+            "type": "boolean",
+            "default": true,
+            "description": "Enables showing highlighted tag pair in ruler 
section",
+            "scope": "resource"
+          },
+          "vscode-dfdl.highlightSelfClosing": {
+            "type": "boolean",
+            "default": false,
+            "description": "Should self-closing tags be highlighted",
+            "scope": "resource"
+          },
+          "vscode-dfdl.highlightFromContent": {
+            "type": "boolean",
+            "default": true,
+            "description": "Whether to highlight matching tag from inside the 
tag content",
+            "scope": "resource"
+          },
+          "vscode-dfdl.highlightFromName": {
+            "type": "boolean",
+            "default": true,
+            "description": "Whether to highlight matching tag from the tag 
name",
+            "scope": "resource"
+          },
+          "vscode-dfdl.highlightFromAttributes": {
+            "type": "boolean",
+            "default": true,
+            "description": "Whether to highlight matching tag from the tag 
attributes",
+            "scope": "resource"
+          },
+          "vscode-dfdl.noDefaultEmptyElements": {
+            "type": "boolean",
+            "default": false,
+            "description": "Don't use default HTML empty elements",
+            "scope": "resource"
+          },
+          "vscode-dfdl.customEmptyElements": {
+            "type": "array",
+            "default": null,
+            "description": "Custom empty elements in addition to the default 
HTML empty elements",
+            "scope": "resource"
+          },

Review Comment:
   So empty element tags are I believe items that from what I found are the 
internet are
   
   ```
   An element that does not have an enclosing tag is called an empty element. 
Adding the closing tags to the
   empty elements will be invalid syntax. The empty elements don’t have any 
child nodes. In short, Empty
   elements are self- closing or void and not container tags. The empty 
elements are used to embed images,
   lists, breaks, horizontal lines, hyperlinks, for input, meta-data, area, 
etc. For instance, <p> tag had 
   a closing tag hence it was not an empty element.
   ```
   Examples of these were `<br>`, `<input>` and `<source>`. So the first would 
be not using the empty element then the other is that we added our own custom 
empty elements (not sure what they are). @rthomas320 Really steamlined this so 
I am not as knowledge as some of this stuff as he is



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to