[
https://issues.apache.org/jira/browse/DAFFODIL-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544369#comment-17544369
]
Dave Thompson commented on DAFFODIL-2696:
-----------------------------------------
This ticket is reference in commit comment for commit
e56c5801ebced6ab31ca3bc0f7958bb30a6a8aad, however the ticket was not marked as
resolved or commented.
Verified changes identified in commit comments were implemented.
Verified affected daffodil subproject sbt test suites execute successfully,
including modified tests.
Note:
In the commit “e56c5801ebced6ab31ca3bc0f7958bb30a6a8aad” comments for files
parser.h and unparser.h states “Change parse_fill_bytes to take end_bitPos0b
instead of end_bytePos0b.”
The actual change shows (via gitk) that parse_fill_bytes was changed to take
end_bytePos0b instead of end_position, see below. Which is correct.
-extern void parse_fill_bytes(size_t end_position, PState *pstate);
+extern void parse_fill_bytes(size_t end_bytePos0b, PState *pstate);
If this ticket is fully resolved it needs to be marked as resolved and
commented as such before it can be closed.
> Extend runtime2 to N-bit booleans and integers (1 <= N <= 64)
> -------------------------------------------------------------
>
> Key: DAFFODIL-2696
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2696
> Project: Daffodil
> Issue Type: Improvement
> Components: Back End C-Generator
> Reporter: John Interrante
> Assignee: John Interrante
> Priority: Major
> Fix For: 3.4.0
>
>
> Allow runtime2 to read and write N-bit booleans and integers where N is an
> explicit length from 1 to 64 bits. Add C-language unit tests for easier
> debugging of N-bit-long numbers (requires Criterion test framework with MIT
> license, https://github.com/Snaipe/Criterion, but never used by or deployed
> with Daffodil itself so no need to change Daffodil's LICENSE or NOTICE
> files). Fix issue overwriting C fields when initializing ERDs and fields of
> C structures containing choices within choices. Reduce differences between
> runtime1 and runtime2 when printing float numbers in XML infosets.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
