Shanedell commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r886228880


##########
package.json:
##########
@@ -63,24 +75,42 @@
     "webpack-cli": "^3.3.12"
   },
   "main": "./dist/ext/extension.js",
-  "browser": "./dist/web/extension.js",
   "activationEvents": [
+    "onLanguage:dfdl",
     "onDebugResolve:dfdl",
     "onDebugDynamicConfigurations:dfdl",
     "onCommand:extension.dfdl-debug.getProgramName",
     "onCommand:extension.dfdl-debug.getDataName",
     "onCommand:extension.dfdl-debug.runEditorContents",
     "onCommand:extension.dfdl-debug.debugEditorContents",
-    "onCommand:launch.config"
+    "onCommand:launch.config",
+    "onCommand:data.edit",
+    "onCommand:omega_edit.version",
+    "onCommand:toggle.experimental"
   ],
   "workspaceTrust": {
     "request": "never"
   },
   "contributes": {
-    "snippets": [
+    "languages": [
       {
-        "language": "xml",
-        "path": "./snippets/dfdl.json"
+        "id": "dfdl",
+        "aliases": [
+          "dfdl",
+          "dfdl"
+        ],
+        "extensions": [
+          ".xsd",
+          ".xml"
+        ],
+        "configuration": "./language/dfdl.json"
+      }
+    ],
+    "grammars": [
+      {
+        "language": "dfdl",
+        "scopeName": "text.xml.dfdl.xsd",

Review Comment:
   I definitely don't think it matter as long as it unique but if that is 
preferred amongst the community I have no issue with the change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to