Shanedell commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r889183526
##########
project/Rat.scala:
##########
@@ -22,8 +22,13 @@ object Rat {
lazy val excludes = Seq(
// git files
file(".git"),
- // json files -- these ones do not support comments
- file("snippets/dfdl.json"),
+ /**
+ * Can't add license headers in JSON files.
+ * Adding a license attribute breaks things in some of these fiels as
well.
Review Comment:
@rt320 would you be able to comment on this? I am not sure on
`language/dfdl.json`.
`language/syntaxes/dfdl.tmLanguage.json` seems to be based off something
however since I noticed this in the file
```json
"information_for_contributors": [
"This file has been converted from
https://github.com/atom/language-xml/blob/master/grammars/xml.cson";,
"If you want to provide a fix or improvement, please create a
pull request against the original repository.",
"Once accepted there, we are happy to receive an update
request."
]
```
but I would say its possible `language/syntax.json` was gotten from somewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
