Shanedell commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r893741175
##########
package.json:
##########
@@ -186,18 +229,49 @@
"category": "Daffodil Debug",
"enablement": "!inDebugMode",
"icon": "$(debug-configure)"
+ },
+ {
+ "command": "toggle.experimental",
+ "title": "Enable Experimental Features",
+ "category": "Daffodil Debug"
+ },
+ {
+ "command": "omega_edit.version",
+ "title": "Omega Edit Ω Version Info",
+ "category": "OmegaEdit",
+ "enablement": "experimentalFeaturesEnabled"
+ },
+ {
+ "command": "data.edit",
+ "title": "Data Editor",
+ "category": "OmegaEdit",
+ "enablement": "experimentalFeaturesEnabled"
+ },
+ {
+ "command": "position.goto",
+ "title": "Go to position",
+ "category": "OmegaEdit",
+ "enablement": "experimentalFeaturesEnabled"
+ }
+ ],
+ "keybindings": [
+ {
+ "command": "position.goto",
+ "key": "ctrl+alt+g",
+ "mac": "ctrl+cmd+g",
+ "when": "editorTextFocus"
}
],
"breakpoints": [
{
- "language": "xml"
+ "language": "dfdl"
}
],
"debuggers": [
{
"type": "dfdl",
"languages": [
- "xml"
+ "dfdl"
Review Comment:
So in a way you can somewhat import xml extension and go based off that of
that, which is what we were doing with snippets previously. However, there are
limitations to what you can do with that as you can’t change, add or update
certain aspect and it also becomes confusing with auto completion as you will
have duplicate items as one will be for xml and one for dfdl. These are the
main reasons we went about things this way as it gives us more flexibility with
how the language extension works that we won’t get if we just base off xml. It
does duplicate things from xml but again we were okay with this because in the
long run it will be better for dfdl language to be as flexible as possible as
well as making sure the Apache community is in full control of how the language
extension functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
