[
https://issues.apache.org/jira/browse/DAFFODIL-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554850#comment-17554850
]
Mike Beckerle edited comment on DAFFODIL-2683 at 6/16/22 1:46 AM:
------------------------------------------------------------------
A WIP PR for a start at this is [https://github.com/apache/daffodil/pull/803]
I have learned the hard way that IntelliJ IDEA IDE cannot simply drag-n-drop
the packages around and do the right thing.
It seemingly hangs, but after having modified files to remove lots of imports.
I waited over 1/2 hour for it to do one package drag-drop and eventually gave
up.
This will have to be done via scripting and by hand.
The change set really should look like little more than ".lib" showing up in
import statements and in daffodil-propgen.
What makes this somewhat tedious is that one cannot just bulk replace say,
org.apache.daffodil.api with org.apache.daffodil.lib.api. Because there are
other modules also providing that package, and they will be renamed
differently.
So we have to move everything, see what imports are broken. Each broken import
can then be fixed in bulk across all files.
It's still something that requires a bulk change across all file imports per
each symbol that is changing package.
was (Author: mbeckerle):
I have learned that IntelliJ IDEA IDE cannot simply drag-n-drop the packages
around and do the right thing.
It seemingly hangs, but after having modified files to remove lots of imports.
I waited over 1/2 hour for it to do one package drag-drop and eventually gave
up.
This will have to be done via scripting and by hand.
The change set really should look like little more than ".lib" showing up in
import statements and in daffodil-propgen.
What makes this somewhat tedious is that one cannot just bulk replace say,
org.apache.daffodil.api with org.apache.daffodil.lib.api. Because there are
other modules also providing that package, and they will be renamed
differently.
So we have to move everything, see what imports are broken. Each broken import
can then be fixed in bulk across all files.
It's still something that requires a bulk change across all file imports per
each symbol that is changing package.
> Don't split packages across jars - OGSI packaging requirements
> --------------------------------------------------------------
>
> Key: DAFFODIL-2683
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2683
> Project: Daffodil
> Issue Type: Bug
> Components: General
> Affects Versions: 3.3.0
> Reporter: Mike Beckerle
> Priority: Major
> Fix For: 3.4.0
>
>
> A user wants to use daffodil inside Apache Karaf, which uses OGSi containers.
> Converting a jar to an OGSi container is feasible; however, there is an
> underlying assumption that a package is not split across such containers.
> As of daffodil 3.3.0, the package structure is not organized this way. The
> packages are orthogonal to the modules.
> For example org.apache.daffodil.processors is split across 6 modules:
> * daffodil-io
> * daffodil-lib
> * daffodil-macro-lib (which shouldn't create a jar, but still it mentions
> the package)
> * daffodil-runtime1
> * daffodil-runtime1-unparser
> * daffodil-tdml-lib (only in test code, which shouldn't impact the jar)
> The requirement is for each package to end up in exactly and only one Jar.
> This ticket possibly interacts with other refactoring tickets that are open
> such as DAFFODIL-2536.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
