stevedlawrence commented on PR #184: URL: https://github.com/apache/daffodil-vscode/pull/184#issuecomment-1158943957
They still need two +1's like normal PRs. We also have a wiki page about Scala Steward that describes what checks should be done: https://cwiki.apache.org/confluence/display/DAFFODIL/Scala+Steward The same idea applies to dependabot, though the steps for making updates if needed is a bit different. Here are some previously reviewed and merged PR's updating dependencies in Daffodil: https://github.com/apache/daffodil/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Aclosed+scala-steward If you take a look at the comments in those PR's you can see examples for the proces. The +1 comments follow the suggested format. Here's a template I usually use for comments: ```markdown - [X] **Do all automated continuous integration checks pass?** - [X] **Is the update a patch, minor, or major update?** - [X] **Is the license still compatible with ASF License Policy?** - [X] **Have any changes been made to LICENSE/NOTICE files that need to be incorporated?** - [X] **Have any transitive dependencies been added or changed?** ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
