Shanedell commented on code in PR #219:
URL: https://github.com/apache/daffodil-vscode/pull/219#discussion_r918337915
##########
server/core/src/main/scala/org.apache.daffodil.debugger.dap/DAPodil.scala:
##########
@@ -194,7 +194,7 @@ class DAPodil(
case Left(errors) =>
state.set(DAPodil.State.FailedToLaunch(request, errors, None)) *>
Logger[IO].warn(show"error parsing launch args:
${errors.mkString_(", ")}") *> session
- .sendResponse(request.respondFailure(Some(show"error parsing
launch args: ${errors.mkString_(", ")}")))
+ .sendResponse(request.respondFailure(Some(show"error parsing
launch args: ${errors.mkString_(", ")}")))
Review Comment:
Same issue
https://github.com/apache/daffodil-vscode/pull/219#discussion_r918337631 will
look into ignoring spacing items
##########
src/daffodilDebugger.ts:
##########
@@ -204,7 +204,8 @@ export async function getDebugger(
name: artifact.scriptName,
cwd:
`${rootPath}/daffodil-debugger-${daffodilVersion}-${LIB_VERSION}/bin/`,
hideFromUser: false,
- shellPath: artifact.scriptName,
+ shellPath: '/bin/bash',
Review Comment:
Yeah this was not supposed to be added that was my fault will remove on next
commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
