stevedlawrence commented on issue #121:
URL:
https://github.com/apache/daffodil-vscode/issues/121#issuecomment-1187513776
Sorry, I was on vacation and didn't get a chance to review the merged change.
I'm not sure the merged commit addresses my original concern in this ticket.
The new code still overwrites the LICENSE/NOTICE files in the root and restores
them, it just does it in a different way:
```typescript
fs.renameSync('LICENSE', 'tmp.LICENSE')
fs.renameSync('NOTICE', 'tmp.NOTICE')
fs.copyFileSync('build/bin.NOTICE', 'NOTICE')
fs.copyFileSync('build/bin.LICENSE', 'LICENSE')
...
fs.rmSync('LICENSE')
fs.rmSync('NOTICE')
fs.renameSync('tmp.LICENSE', 'LICENSE')
fs.renameSync('tmp.NOTICE', 'NOTICE')
```
My main concern with this ticket is that we shouldn't be overwritting the
root LICENSE/NOTICE files. Similarly, the new change also executes git to undo
changes, which is fragile--we really don't want the chance to automatically
revert someones changes to these files if something in the build goes wrong.
I thought your suggestion of coyping things into a new build/package
directory and building everything out of that seemed reasonable. Did that not
work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
