Shanedell commented on code in PR #232:
URL: https://github.com/apache/daffodil-vscode/pull/232#discussion_r923981476
##########
package.json:
##########
@@ -25,21 +25,19 @@
},
"scripts": {
"omega-edit-download": "node -e
\"require('./build/scripts/omega_edit_download.ts').downloadServer()\"",
- "vscode:prepublish": "yarn run package-ext",
"precompile": "node -p \"'export const LIB_VERSION = ' +
JSON.stringify(require('./package.json').version) + ';'\" > src/version.ts",
"compile": "tsc -p ./ && yarn omega-edit-download",
"lint": "yarn run prettier src -c",
"watch": "yarn omega-edit-download && webpack --watch --devtool
nosources-source-map --config ./build/extension.webpack.config.js",
"watch2": "tsc -watch -p ./",
- "package": "vsce package",
+ "webpack": "webpack --mode production --config
./build/extension.webpack.config.js",
+ "package": "vsce package",
"publish": "vsce publish",
- "package-ext": "webpack --mode production --config
./build/extension.webpack.config.js",
"pretest": "yarn run compile",
"test": "node node_modules/mocha/bin/_mocha -u tdd --timeout 999999
--colors ./out/tests",
"sbt": "sbt universal:packageBin",
- "prebuild": "node -e
\"require('./build/scripts/process_build.ts').prebuild()\"",
- "build": "yarn sbt && yarn install && yarn compile && yarn package",
- "postbuild": "node -e
\"require('./build/scripts/process_build.ts').postbuild()\""
+ "prebuild": "yarn sbt && yarn install && yarn compile && yarn webpack",
+ "build": "node -e
\"require('./build/scripts/process_build.ts').build_package()\""
Review Comment:
So basically compile should be everything dealing with creating the out js
file, extension webpack file, I think technically it should have sbt running as
well, maybe I left that out to make it quicker I am not fully sure. But I think
with removing the `vsce package` command we actually replace the `build` script
with `package` as that is what it is really doing anyway. Would that make sense
to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
