stevedlawrence commented on code in PR #232: URL: https://github.com/apache/daffodil-vscode/pull/232#discussion_r924492587
########## build/scripts/package.ts: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// @ts-nocheck <-- This is needed as this file is basically a JavaScript script +// but with some TypeScript niceness baked in +const fs = require('fs') +const path = require('path') +const glob = require('glob') +const execSync = require('child_process').execSync +const pkg_dir = 'dist/package' + +async function copyGlob(pattern) { + glob(pattern, (error, files) => { + for (var i = 0; i < files.length; i++) { + // Skip dirs as they are most likely listed in the .vscodeignore as well + if (fs.statSync(files[i]).isDirectory()) continue Review Comment: > > Why skip directories that match the glob? If they are listed in .vscodeignore don't we want them too? > > So with the copy method you can't copy directories only files. That is why sub-directories are skipped, but I guess you could just run another glob recursively, is that what you mean? So something like > > ``` > if (fs.statSync(files[i]).isDirectory()) { > copyGlob(`${files[i]}/*`) > continue > } > ``` What about just special case directories? I think you used to have that, e.g. ```node if (dst[i].isDirectory) { fs.mkdirSync(dst, { recursive: true }) } else { // file copy stuff } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
