tuxji commented on code in PR #827:
URL: https://github.com/apache/daffodil/pull/827#discussion_r947400139
##########
daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStreamImplMixin.scala:
##########
@@ -185,6 +185,20 @@ trait DataOutputStreamImplMixin extends
DataStreamCommonState
Assert.usageError("You cannot set the abs starting bit pos again.")
}
checkInvariants()
+
+ // We now know the absolute starting position of this DOS. If we also know
its
+ // length, then we can set the absolute starting position of the next DOS
as well
+ // (if one exists and if it doesn't already have an absolution starting
Review Comment:
absolution -> absolute
##########
daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStreamImplMixin.scala:
##########
@@ -149,7 +149,7 @@ trait DataOutputStreamImplMixin extends
DataStreamCommonState
* of the former starting bit pos so as to be able to
* convert relative positions to absolute positions correctly.
*/
- protected final def maybeAbsStartingBitPos0b = {
+ final def maybeAbsStartingBitPos0b = {
Review Comment:
Now that this method is public, it should have an explicit return type
annotation per Scala's style
[guide](https://docs.scala-lang.org/style/types.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
