stevedlawrence opened a new pull request, #829: URL: https://github.com/apache/daffodil/pull/829
Commit 3b213ce30b deprecated InfosetOutputter functions that returned false, and instead expected them to throw an Exception. If an implementation returned false from one of these functions, then Daffodil threw a usageError and stopped processing, with the assumption that no one actually used this. Unfortunately, the SAXInfosetOutputter actually does return false to signify errors, which could lead to usageErrors when outputting SAX (or EXI which uses SAX behind the scenes). This changes the InfosetOutputter API to remove the Boolean return value, and changes all concrete implementations to use this new API and throw an Exception when an error is encountered. This breaks backwards compatibility, but ensures consistence and a cleaner API. Note that this does not completely address DAFFODIL-2721, but is a quick change to fix the SAX and EXI regression. Additional work is needed to fully resolve the issue. DAFFODIL-2721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
