[
https://issues.apache.org/jira/browse/DAFFODIL-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583065#comment-17583065
]
Dave Thompson commented on DAFFODIL-2721:
-----------------------------------------
Looking at commit f836f33b9a76ef4c18a25f30b8844ea99b19f11e updates.
Verified the specified commit (commit f836f33b9a76ef4c18a25f30b8844ea99b19f11e)
is included in the latest pull from the daffodil repository.
Verified, via review, changes identified in commit comment were implemented.
Verified the all affected daffodil subproject sbt test suite execute
successfully.
Ran the -I exi option on the 4 formats failing regression and verified they no
longer get the "exceptions.Abort: InfosetOutputter false return value is
deprecated" errors.
However, I'm now getting "[error] Schema Definition Error: Failed to start
infoset simple element: java.lang.StringIndexOutOfBoundsException: ..." when
parsing these same formats. It is expected that when the ticket is resolved, an
update addressing these issues will be included and need to be verified.
Note: these SDEs do not occur with -I sax execution.
> Standardize InfosetInputter and InfosetOutputter error handling
> ---------------------------------------------------------------
>
> Key: DAFFODIL-2721
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2721
> Project: Daffodil
> Issue Type: Bug
> Reporter: Steve Lawrence
> Priority: Critical
>
> The API for InfosetInputetr and InfosetOutputter is not well defined. In the
> InfosetOutputter API we have deprecated the use of the boolean return values,
> but have not changed the actual API.
> In both cases, implementations are expected to throw exceptions to report
> errors.
> In the InfosetOutputter, we catch all Exceptions and convert them to an SDE.
> In the InfosetInputter catches various kinds of exceptions based on
> InvalidInfosetExcpetion, but only documents
> NonTextFoundInSimpleContentException. It's not clear if try/catch'es wrap all
> calls to the InfosetInputter.
> We should double check that everything is correct. We may also want to create
> a specific exception for both the inputter and outputter that are consistent
> in naming (e.g. InfosetInputterException/InfosetOutputterException) and use
> these correctly and consistently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
