stevedlawrence commented on PR #294: URL: https://github.com/apache/daffodil-vscode/pull/294#issuecomment-1252537488
The commit message isn't quite right. These lines should be removed: ``` -renamed function getNsPrefix to getXsdNsPrefix -added additional comments to getXsdNsPrefix to notify that a colon is include with the returned prefix -replaced if statement to test for "schema" with a regex ``` The commit does not actually do these things. Those were changes made due to review comments, but in the context of this single squashed commit do not happen. There's also duplicate sentences in the commit message. And you only need to include the related issue at the end, with "Closed #122". It does not need to be on the first line. Also, I'm not sure if the meaning of "Resolves Remove Prefixes" is very clear. Should that be something like "Suggest namespace prefixes based on the schema element prefix" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
