stevedlawrence commented on code in PR #846:
URL: https://github.com/apache/daffodil/pull/846#discussion_r977585645
##########
daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala:
##########
@@ -313,7 +313,7 @@ class CLIConf(arguments: Array[String]) extends
scallop.ScallopConf(arguments) {
val config = opt[File](short = 'c', argName = "file", descr = "XML file
containing configuration items")
val vars = props[String](name = 'D', keyName = "variable", valueName =
"value", descr = "Variables to be used when parsing. Can be prefixed with
{namespace}.")
- val infosetType = opt[InfosetType.Type](short = 'I', argName =
"infoset_type", descr = "Infoset type to output. Use 'xml', 'scala-xml',
'json', 'jdom', 'w3cdom', 'sax', 'exi', or 'null'. Defaults to 'xml'.", default
= Some(InfosetType.XML))
+ val infosetType = opt[InfosetType.Type](short = 'I', argName =
"infoset_type", descr = "Infoset type to output. Use 'xml', 'scala-xml',
'json', 'jdom', 'w3cdom', 'sax', 'exi', 'exisa', or 'null'. Defaults to
'xml'.", default = Some(InfosetType.XML))
Review Comment:
Thoughts on changing this to something like:
```scala
descr = "Infoset type to output. Type can be: " +
InfosetType.values.mkString(", ") + ". Defaults to xml".
```
This way we don't need to remember to update the help everytime a new
infoset type is added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
