stevedlawrence commented on code in PR #319:
URL: https://github.com/apache/daffodil-vscode/pull/319#discussion_r989217357
##########
.gitignore:
##########
@@ -54,3 +54,9 @@ tmp.*
# ignore omega-edit scala server package file
src/omega_edit/omega-edit-scala-server*
+
+# scala debugger settings
+**/.bloop
+
+# JetBrains IDE settings
+.idea/
Review Comment:
These should not go in this file. IDE specific ignores should go in a ignore
file specific to a user's environment. The daffodil .gitignore file has a
comment with more details.
##########
.github/workflows/CI.yml:
##########
@@ -102,6 +98,11 @@ jobs:
env:
SBT: sbt -J-Xms1024m -J-Xmx5120m -J-XX:ReservedCodeCacheSize=512m
-J-XX:MaxMetaspaceSize=1024m ++2.12.15
steps:
+ - name: Setup Java 11
+ uses: actions/[email protected]
+ with:
+ distribution: temurin
+ java-version: 11
- uses: actions/[email protected]
- name: Install Node.js
Review Comment:
Weren't these changes in another PR? These feel familiar? (I'm on my phone
so it's hard to check)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
