Shanedell commented on PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#issuecomment-1301146379
> +1
>
> Changes look reasonable. Though it looks like there are a number of new
dependencies, I assume pulled in by the new version of omega edit? Have those
been verified to be ASF compatible and updates made to the
`build/package/{NOTICE,LICENSE}` files?
@stevedlawrence I do need to update that, will do it in this PR before
merging it. I know some were using Apache licensing without a notice in there
repo. Can these possibly still be listed inside of the `build/package/NOTICE`
and just do something like this
```
- '@grpc/grpc-js' packaged in extension/dist/ext/extension.js
NOTICE not provided. See repo at
https://github.com/grpc/grpc-node/tree/master
```
so that we know which dependencies are not known to be a part of the LICENSE
or NOTICE? Also making sure we don't keep rechecking dependencies that we know
are approved but just aren't marked down somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
