stevedlawrence commented on code in PR #875:
URL: https://github.com/apache/daffodil/pull/875#discussion_r1021834300
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala:
##########
@@ -825,50 +524,15 @@ class DataProcessor private[japi] (private var dp:
SDataProcessor)
val ur = dp.unparse(input, output).asInstanceOf[SUnparseResult]
new UnparseResult(ur)
}
-
- /**
- * Unparse a JDOM2 infoset
- *
- * @param output the byte channel to write the data to
- * @param infoset the infoset to unparse, as a jdom event cursor
- * @return an object with contains the result and/or diagnostic information
- */
- @deprecated("Use unparse(InfosetInputter, WritableByteChannel)", "2.0.0")
- def unparse(output: WritableByteChannel, infoset: org.jdom2.Document):
UnparseResult = {
- val input = new JDOMInfosetInputter(infoset)
- unparse(input, output)
- }
}
/**
- * Result of calling
[[DataProcessor#parse(java.nio.channels.ReadableByteChannel, InfosetOutputter,
long)]], containing
+ * Result of calling [[DataProcessor#parse(InputSourceDataInputStream,
InfosetOutputter)]], containing
* the diagnostic information, and the final data location
*/
class ParseResult private[japi] (pr: SParseResult, deprecatedOutput:
Maybe[JDOMInfosetOutputter])
extends WithDiagnostics(pr) {
- /**
Review Comment:
Probably. I also wonder if we should change the default values of some
tunables. For example, I found this in Expression.scala:
```scala
if (tunable.allowExpressionResultCoercion) {
SDW(
WarnID.DeprecatedExpressionResultCoercion,
"In expression %s, result type (%s) should be manually cast to the
expected type (%s) with the appropriate constructor." +
"Performing deprecated automatic conversion.",
wholeExpressionText,
inherentType,
targetType)
```
We may want to change the default value of `allowExpressionResultCoercion`
to false. Grepping for 'deprecate' in comments may potentially find others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
