[ 
https://issues.apache.org/jira/browse/DAFFODIL-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634478#comment-17634478
 ] 

John Interrante commented on DAFFODIL-2133:
-------------------------------------------

We could make build.sbt run the formatter automatically during each build if 
the formatter handles 99% of cases satisfactorily, the code can disable the 
formatter in the 1% of cases where it messes up, and the devs agree to 
automatic formatting.  We already have a CI check to detect locally modified 
source code files during a CI build so all pull requests' code changes would 
have to go through the formatting unchanged or fail the CI check.

Also, DEVELOP.md mentions this ticket so please update DEVELOP.md when this 
ticket is resolved.

> Enable and configure sbt-scalariform/scalafmt plugin
> ----------------------------------------------------
>
>                 Key: DAFFODIL-2133
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2133
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Infrastructure
>            Reporter: Steve Lawrence
>            Priority: Minor
>              Labels: beginner
>
> We should enable the [sbt-scalariform|https://github.com/sbt/sbt-scalariform] 
> plugin to enable style checks to fail builds that do not meet style 
> guidelines. This probably means fixing a bunch of code that doesn't follow 
> the guidelines before we can actual turn it on in builds.
> The configuration of the plugin can also be used as guidance for how to 
> configure IDE's that do autoformatting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to