Shanedell commented on code in PR #875:
URL: https://github.com/apache/daffodil/pull/875#discussion_r1024190078


##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/XMLTextInfosetInputter.scala:
##########
@@ -191,9 +191,6 @@ object XMLTextInfoset {
 class XMLTextInfosetInputter private (input: Either[java.io.Reader, 
java.io.InputStream])

Review Comment:
   @stevedlawrence To get this to work the `private` keyword need deleted for 
example for `JsonInfosetInputter` I needed to make the class def be this
   ```scala
   class JsonInfosetInputter(input: java.io.InputStream)
   ```
   instead of having
   ```scala
   class JsonInfosetInputter private (input: java.io.InputStream)
   ```
   would this be how we wanted to do it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to