mbeckerle commented on code in PR #381: URL: https://github.com/apache/daffodil-vscode/pull/381#discussion_r1046135958
########## docs/Makefile: ########## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +SRCDIR := .wiki/ +DOCX = $(addsuffix .docx,$(basename $(notdir $(wildcard $(SRCDIR)*.md)))) + +$(SRCDIR): + git clone https://github.com/apache/daffodil-vscode.wiki.git .wiki + +%.docx: + pandoc -t docx -f markdown -o $@ $(addprefix $(SRCDIR),$(addsuffix .md,$(basename $@))) Review Comment: That character U+1F4DD is in the Unicode supplemental characters area which is for chars with codes above U+FFFF, which are often not supported by Java-based software, or anything that assumes a wchar is 2 bytes. There is also often no font support in many fonts, etc. It takes 2 16-bit code units to represent that character in a Java string or any other system with 16-bit code units for strings. It takes 4 bytes in UTF-8. Maybe the easiest thing would be to just use a Unicode character with codepoint below U+FFFF. There are plenty of useful symbolic glyphs without having to reach into the suppmental unicode chars. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
