scholarsmate commented on code in PR #371:
URL: https://github.com/apache/daffodil-vscode/pull/371#discussion_r1049067549
##########
src/tests/suite/adapter.test.ts:
##########
@@ -20,8 +20,11 @@ import * as path from 'path'
import { DebugClient } from 'vscode-debugadapter-testsupport'
suite('Daffodil Debug Adapter', () => {
- const DEBUG_ADAPTER = path.resolve('out/adapter/debugAdapter.js')
- const PROJECT_ROOT = path.resolve('.')
+ const DEBUG_ADAPTER = path.join(
+ __dirname,
+ '../../../out/adapter/debugAdapter.js'
+ )
+ const PROJECT_ROOT = path.join(__dirname, '../../../')
Review Comment:
I think we should still try to resolve these paths instead of using these
relative paths, but I won't hold up this PR over it. It probably merits a
"technical debt" ticket though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
