stevedlawrence commented on code in PR #102:
URL: https://github.com/apache/daffodil-site/pull/102#discussion_r1050009014
##########
site/_includes/download-list.html:
##########
@@ -1,7 +1,8 @@
{% for file in include.artifacts %}
<div class="row">
<div class="col-sm-6">
- <a href="{{ include.artifact-root | append: include.prefix | append: file
}}">{{ file }}</a>
+ {% if include.apache %} {% assign params = "?action=download" %} {% endif
%}
+ <a href="{{ include.artifact-root | append: include.prefix | append: file
| append: params }}">{{ file }}</a>
Review Comment:
On our download page we list both Apache releases and non-Apache release
made before Daffodil joined the apache incubator. This condition makes it so
only releases made after that get the `?action=download` thing. The
`page.apache` thing is a flag in each release page that says whether or not
it's one of these Apache release.
##########
site/_layouts/release.html:
##########
@@ -45,6 +45,7 @@ <h4>Source</h4>
checksum-root=page.checksum-root
artifact-root=page.artifact-root
prefix=prefix
+ apache=page.apache
Review Comment:
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
