Shanedell opened a new pull request, #388:
URL: https://github.com/apache/daffodil-vscode/pull/388
Run daffodil-debugger in CI.
- Update tests to run the daffodil-debugger in the CI, then run tests
against it.
- Created two simple tests to ensure the infoset files are created.
- Code needed updated to split out a lot of common code:
- Create a new daffodilDebuggerUtils file that holds functions that are
common to get the debugger running, stopped, etc.
- Create a function for doing os checks to remove a lot of duplicated code
and limit number of types it shows up in the code.
- Update the test schema to be a proper schema so it could be parsed by the
debugger.
- Create a src/tests/common.ts for common variables that a few different
tests use. Later on this include more vars and functions if needed.
- Support Java 8
- Ignore com.microsoft.java for scala-steward as the version used is the
last one that supports java 8
Closes #301
Closes #337
Closes #377
Notes:
- For some reason in the CI it seems that sometimes the two new TS tests for
making sure an infoset is created sometime will decide to fail. This seems to
happen only on macos though.
- Currently for both tests to run we need to run a separate instance of the
daffodil-debugger before hand. I think we should add an option to the
daffodil-debugger to allow multiple connections and not automatically close
after one connection is done debugging/running. This would make it so in the
future if we have say ten tests that need the debugger, we can just run the
debugger once and run all the tests as opposed to having to run the debugger
before each test (in this scenario we would run it 10 times). I think this may
be what causes the issue in the macos CI to sometimes fail, as I think
sometimes the 1st instance of the debugger could have not been killed before
the 2nd instance is trying to run. How does everybody else feel about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
