tuxji commented on code in PR #897:
URL: https://github.com/apache/daffodil/pull/897#discussion_r1053802589


##########
containers/release-candidate/src/daffodil-release-candidate:
##########
@@ -300,6 +301,17 @@ case $PROJECT_REPO in
     yarn package
     cp *.vsix $DAFFODIL_RELEASE_DIR/bin/
 
+    echo "Building Extension Docs..."
+    doc_name="Apache-Daffodil-Extension-for-Visual-Studio-Code-$VERSION.docx"
+    git clone https://github.com/apache/daffodil-vscode.wiki.git .wiki
+    pandoc -t docx -f markdown -o .wiki/$doc_name .wiki/*.md

Review Comment:
   Does pandoc allow you to create a single HTML file from multiple markdown 
files?  That is, does the following work as well?
   
   ```shell
       echo "Building Extension Docs..."
       doc_name="Apache-Daffodil-Extension-for-Visual-Studio-Code-$VERSION.html"
       git clone https://github.com/apache/daffodil-vscode.wiki.git .wiki
       pandoc -t html -f markdown -o .wiki/$doc_name .wiki/*.md
   ```
   
   Everyone has a web browser and can read a HTML file, but I'm not sure 
everyone has a word processor which can read a .docx file.  Are there any 
compelling reasons for picking docx as the format for reading documentation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to