stevedlawrence commented on code in PR #821:
URL: https://github.com/apache/daffodil/pull/821#discussion_r1055532880


##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/InfosetOutputter.scala:
##########
@@ -54,11 +54,12 @@ trait InfosetOutputter {
    * @param diSimple the simple element that is started. Various fields of
    *                 DISimple can be accessed to determine things like the
    *                 value, nil, name, namespace, etc.
+   * @param xmlOutputStyle the string that determines how to print data.
    * @return true on sucess, false if there was an error and Daffodil should 
stop all
    *         future calls to the InfosetOutputter
    */
 
-  def startSimple(diSimple: DISimple): Boolean
+  def startSimple(diSimple: DISimple, xmlOutputStyle: String): Boolean

Review Comment:
   Yep, this has been addressed.



##########
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dafext.xsd:
##########
@@ -559,6 +559,17 @@
             </xs:restriction>
           </xs:simpleType>
         </xs:element>
+        <xs:element name="xmlOutputStyle" type="xs:string" default="none" 
minOccurs="0">
+          <xs:annotation>
+            <xs:documentation>
+              values is a whitespace separated list of tokens drawn from this 
set.
+              Values are:
+              - none: (Current behavior - ok if data is not being pretty 
printed, or will not be re-read in, or if whitespace is fungible in the actual 
data format),

Review Comment:
   Tunables aren't used to change this settings anymore, it's now part of the 
XMLTextInfosetOutputter constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to