mbeckerle commented on code in PR #900:
URL: https://github.com/apache/daffodil/pull/900#discussion_r1058548333
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesTextNumber1.scala:
##########
@@ -78,18 +121,18 @@ case class ConvertTextNumberParser(
// will match either all or none of 'str', never part of it. Thus,
// findFirstIn() either matches and it's a zero rep, or it doesn't and it's
// not a zero
- val numValue = zeroRepsRegex.find { _.findFirstIn(str).isDefined } match {
+ val numValue: DataValueNumber = zeroRepsRegex.find {
_.findFirstIn(str).isDefined } match {
case Some(_) => primNumeric.fromNumber(0)
Review Comment:
Also, test with smaller integer types. Virtual decimal points should work
for type xs:byte even.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
