mbeckerle commented on code in PR #900:
URL: https://github.com/apache/daffodil/pull/900#discussion_r1059405800
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesTextNumber1.scala:
##########
@@ -54,11 +56,58 @@ case class ConvertTextCombinatorParser(
}
}
+trait TextDecimalVirtualPointMixin {
+ def textDecimalVirtualPoint: Int
+
+ final protected val divisor = scala.math.pow(10.0, textDecimalVirtualPoint)
+ final protected val multiplier = scala.math.pow(10.0,
textDecimalVirtualPoint)
Review Comment:
Ha! it's really the "magic number" and one code path multiplies by it. the
other divides by it. I'll explain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
