scholarsmate commented on code in PR #402:
URL: https://github.com/apache/daffodil-vscode/pull/402#discussion_r1065760781
##########
src/launchWizard/launchWizard.ts:
##########
@@ -325,13 +294,22 @@ class LaunchWizard {
let stopOnEntry = defaultValues.stopOnEntry ? 'checked' : ''
let trace = defaultValues.trace ? 'checked' : ''
let useExistingServer = defaultValues.useExistingServer ? 'checked' : ''
- let daffodilDebugClasspathAction =
- defaultValues.daffodilDebugClasspathAction === 'append'
- ? defaultConf.daffodilDebugClasspath
- : 'replace'
- let replaceCheck =
- daffodilDebugClasspathAction !== 'append' ? 'checked' : ''
- let appendCheck = daffodilDebugClasspathAction === 'append' ? 'checked' :
''
+
+ let daffodilDebugClasspathList =
+ '<ul id="daffodilDebugClasspathTable" style="list-style: none;
padding-left: 20px;">'
+ if (defaultValues.daffodilDebugClasspath) {
+ let itemArray = defaultValues.daffodilDebugClasspath.split(':')
+ for (var i = 0; i < itemArray.length; i++) {
+ daffodilDebugClasspathList += `
+ <li style="margin-left: -5px;"
onclick="removeDebugClasspathItem(this)">
+ <p id="debug-classpath-li-${itemArray[i]}"
class="debug-classpath-item">
+ <button id="remove-debug-classpath-li-${itemArray[i]}"
class="minus-button" type="button">-</button>
+ ${itemArray[i]}
+ </p>
+ </li>`
Review Comment:
The Data Editor feature will be doing just as you described, sending data
from the extension to the webview for rendering. We'll see how it goes.
Either way we'll get smarter on this pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
