stevedlawrence commented on PR #261: URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1378130342
That makes sense to me. Any `libraryDependencies` added to `project/*.sbt` are available in the root `build.sbt` file, and we really don't need sbt-json if we only need that one play-json dependency. Though, I *think* the sbt convention is for `libraryDependencies` to be added in a `project/build.sbt` file, to differentiate between plugins and configuration. I also just noticed that we parse the package.json file in two different ways in build.sbt. Once to get the `daffodilVersion` using the play-json library and one to get just `version` which uses a regex. We should change those so they are consistent (either both use regex and remove the play-json dep, or both use play-json). Fine to do that in a separate PR/issue if you want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
