stevedlawrence commented on code in PR #908:
URL: https://github.com/apache/daffodil/pull/908#discussion_r1068367020
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/api/DFDLParserUnparser.scala:
##########
@@ -226,84 +221,22 @@ object DFDL {
}
trait DaffodilUnparseContentHandler
- extends ProducerCoroutine
- with org.xml.sax.ContentHandler {
+ extends org.xml.sax.ContentHandler {
def getUnparseResult: UnparseResult
- def enableInputterResolutionOfRelativeInfosetBlobURIs(): Unit
+ def enableResolutionOfRelativeInfosetBlobURIs(): Unit
}
Review Comment:
The trait acts as an interface so that if this .api ever does become public
(which I hope happens some day, it's such a pain having to maintain
daffodil-japi and daffodil-sapi) then this will be the public interface that
users can interact with. But I can definitely see how that could be confusing.
Maybe we rename the implementation to `DaffodilUnparseContentHandlerImpl` to
make it clear it's an implementation of the DaffodilUnparseContentHandler
interface/API.
I'm not sure if we have a standard on fully qualified vs not, but in general
I prefer to not use the fully qualified name, I guess I missed a couple places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
