stevedlawrence commented on PR #423: URL: https://github.com/apache/daffodil-vscode/pull/423#issuecomment-1386013121
I haven't reviewed anything yet, but some high level question: 1. svlete seems to be a gui framework, does VS Code not provide a gui system that uses VS Code native widgets and things? 2. Why is some svelte stuff in a subdirectory/project with it's own package dependencies and sources? How are those incorporated into the main project? 3. Have you verified all the svelte dependencies are ALv2 friendly? Seems like a lot of new dependencies are being added, but maybe it's not as much as it seems. 4. This PR closes 12 issues, can they not be separated into multiple PR's to make the reviewers lives happier? It's so much easier to review multiple small patches. Please try avoid doing a ton of work behind the scenes and pushing it for review when it's all done. Incremental enhancements are sooooo much better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
